[ESSREDUCE] Drop frame_total aux signal#658
Merged
Merged
Conversation
github-actions
Bot
changed the title
ESS histogram monitors now contain a frame_time auxiliary signal which has different dims from the monitor's main signal. That fails the ScippNeXus loader. This change works around that by not loading the frame_total in workflows.
jl-wynen
force-pushed
the
drop-monito-aux-signal
branch
from
7b00e1b to
5867569
Compare
nvaytet
approved these changes
Jun 30, 2026
SimonHeybrock
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESS histogram monitors now contain a frame_time auxiliary signal which has different dims from the monitor's main signal. That fails the ScippNeXus loader.
This change works around that by not loading the frame_total in workflows. This is a partial implementation of scipp/scippnexus#304