refactor: use parameter models from esslivedata#654
Draft
jokasimr wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
essdiffraction
jokasimr
commented
Jun 26, 2026
Comment on lines
+52
to
+67
| DetectorBank.south: {'y': 200, 'x': 500}, | ||
| DetectorBank.north: {'y': 200, 'x': 500}, | ||
| }, | ||
| KeepEvents[RunType]: KeepEvents(False), | ||
| TwoThetaMask: lambda two_theta: ( | ||
| (two_theta < sc.scalar(float('inf'), unit=two_theta.unit)) | ||
| | (two_theta > sc.scalar(float('-inf'), unit=two_theta.unit)) | ||
| ), | ||
| TofMask: None, | ||
| WavelengthMask: None, | ||
| MaskedDetectorIDs: MaskedDetectorIDs({}), | ||
| NeXusDetectorName: "detector", | ||
| DetectorBank: DetectorBank.south, | ||
| Filename[SampleRun]: str(mcstas_powder_silicon_in_vanadium_can()), | ||
| Filename[VanadiumRun]: str(mcstas_powder_vanadium()), | ||
| Filename[EmptyCanRun]: str(mcstas_powder_empty_can()), |
Contributor
Author
There was a problem hiding this comment.
These changes will be revisited or removed.
They were added mainly for debugging purposes.
jokasimr
commented
Jun 26, 2026
| stop=self.stop, | ||
| num=self.num_bins + 1, | ||
| unit=self.unit.value, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Why does this have to be re-implemented here?
Looks like only the dim and descriptions should need to be specified.
jokasimr
commented
Jun 26, 2026
| # TODO: for now, we leave the mapping over detector banks out, because we do not have a | ||
| # method to merge the I(Q) of different banks, and we thus cannot compute a single | ||
| # result from the workflow. So only a single detector bank can be processed at a time. | ||
| # parameter_mappers[NeXusDetectorName] = with_banks |
Contributor
Author
There was a problem hiding this comment.
Comment should not be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #653
This is a codex rewrite of the parameter / workflow widget system using the models from esslivedata.