Avoid unused braces lint for macro generated arguments#158791
Open
chenyukang wants to merge 1 commit into
Open
Avoid unused braces lint for macro generated arguments#158791chenyukang wants to merge 1 commit into
chenyukang wants to merge 1 commit into
Conversation
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158747
This changes the
unused_braceslint to avoid suggesting brace removal for macro arguments when those braces may affectmacro_rules!.But the fragment kind matters:
$e:exprmatches an expression. Both1and{ 1 }are expressions, so removing braces can still leave the macro matching the same kind of input.$b:blockonly matches a block expression written with braces.{ 1 }matches, but1does not.So
call_expr!({ 1 })can usually be simplified tocall_expr!(1), whilecall_block!({ 1 })cannot.It seems a more concrect report need a full
macro_rules!matcher analysis, that seems too heavy forunusedlint.