Skip to content

Add regression test for builtin attr macro values#158786

Open
Ap4sh wants to merge 1 commit into
rust-lang:mainfrom
Ap4sh:ap4sh/issue-145922-builtin-attr-macro-values
Open

Add regression test for builtin attr macro values#158786
Ap4sh wants to merge 1 commit into
rust-lang:mainfrom
Ap4sh:ap4sh/issue-145922-builtin-attr-macro-values

Conversation

@Ap4sh

@Ap4sh Ap4sh commented Jul 4, 2026

Copy link
Copy Markdown

Adds a UI regression test for #145922

The test covers builtin attributes whose value is a macro call on a macro item, including the extra attributes mentioned in the issue thread. windows_subsystem still emits its normal malformed-attribute error; the other cases make sure they don't regress into the delayed ICE again

Fixes #145922

Tested:

  • python3 x.py test tests/ui/attributes/builtin-attr-macro-value-issue-145922.rs --force-rerun -j 2
  • python3 x.py test tidy -j 2

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 4, 2026
@rustbot

rustbot commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @folkertdev (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 22 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE expr in place where literal is expected (builtin attr parsing)

3 participants