feat(env_filter): support no_std#404
Open
cagatay-y wants to merge 2 commits into
Open
Conversation
cagatay-y
changed the title
epage
reviewed
Apr 2, 2026
epage
reviewed
Apr 2, 2026
Contributor
|
FYI I expect PRs to be presented for how they should be reviewed and merged and not for how they were developed. Please clean up the commit history |
cagatay-y
force-pushed
the
feature/filter-no_std
branch
from
b754c66 to
364726a
Compare
cagatay-y
commented
Apr 6, 2026
Author
|
@epage, could you take another look at the PR? |
epage
reviewed
May 23, 2026
epage
reviewed
May 23, 2026
epage
reviewed
May 23, 2026
epage
reviewed
May 23, 2026
cagatay-y
force-pushed
the
feature/filter-no_std
branch
from
364726a to
2a7ae94
Compare
cagatay-y
force-pushed
the
feature/filter-no_std
branch
from
2a7ae94 to
8e062c3
Compare
Author
|
In the latest force-push, in addition to what was raised in the review, I fixed an error I made related to the handling of the features of the |
epage
reviewed
Jun 16, 2026
Co-authored-by: WolverinDEV <git@did.science>
cagatay-y
force-pushed
the
feature/filter-no_std
branch
from
8e062c3 to
f461d05
Compare
Co-authored-by: WolverinDEV <git@did.science>
cagatay-y
force-pushed
the
feature/filter-no_std
branch
from
f461d05 to
132fe86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #378, this PR adds a new default feature
stdthat allows the crate to be used in no_std crates. I tried to incorporate the feedback that was given to the previous PR. Hopefully, I didn't miss anything.The PR is still a breaking change for crates that have the default features disabled and use
Builder::from_env, or expectBuilder::parseto print warnings to stderr and don't have the log target set to stderr.It may make sense to squash 9c70eaf and 663c9c2 (and potentially b754c66). I kept them separate to make sure I don't misattribute the work of the author of the base PR.