Eliminate XPathNode#325
Merged
Merged
Conversation
tompng
force-pushed
the
eliminate_xpathnode
branch
from
959e98a to
136147c
Compare
XPathNode requires :position, but in most case, this :position is not used at all, and just doing useless packing/unpacking.
tompng
force-pushed
the
eliminate_xpathnode
branch
from
136147c to
767d092
Compare
Comment on lines
377
to
382
| target_context = context | ||
| else | ||
| target_context = {:size => nodeset.size} | ||
| if node.is_a?(XPathNode) | ||
| target_context[:node] = node.raw_node | ||
| target_context[:index] = node.position | ||
| else | ||
| target_context[:node] = node | ||
| target_context[:index] = 1 | ||
| end | ||
| target_context[:node] = node | ||
| target_context[:position] = 1 | ||
| end |
| else | ||
| seen = {}.compare_by_identity | ||
| raw_nodes = [] | ||
| nodes = Set.new.compare_by_identity |
| true | ||
| end | ||
| end | ||
| new_nodesets = nodesets |
naitoh
approved these changes
Jun 9, 2026
naitoh
left a comment
naitoh
left a comment
Contributor
There was a problem hiding this comment.
I think it’s much easier to read now.
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XPathNode requires :position, but in most case, this :position is not used at all, and just doing useless packing/unpacking.
Extracted from #315