Update CRuby extension deprecated macros#8
Conversation
|
Quick CI note: the failing
So I don't see an actionable change needed in this PR for that check. |
|
@WilliamK112 Hi,
You should take some time to setup environment locally and check if it builds and passes tests. The setup on Windows is surely harder than on *nix, but it's worth learning for Ruby+C beginners. |
|
Thanks for the nudge. I set up a local Ruby+C environment for this branch on Windows using MSYS2/UCRT:
I then installed the gem dependencies and ran the native build/test path locally: So the extension builds and the current CRuby tests pass on this Windows/MSYS2 UCRT setup. I also cleaned the generated local build artifacts afterward; no PR changes were needed. |
|
Thank you, sounds good to me. |
Summary
DATA_PTRuses withRTYPEDDATA_DATAfor objects allocated throughTypedData_Wrap_Struct.Qnil/Qtrue/Qfalse/Qundefconstants with theRUBY_Q*forms.Closes #6
Closes #7
Validation
rg -n \b(DATA_PTR|Qnil|Qtrue|Qfalse|Qundef)\b ext/gettextpo/gettextpo.creturns no matchesclang-format --dry-run --Werror ext/gettextpo/gettextpo.cgit diff --checkNotes
I could not run
bundle exec rake testlocally because this Windows environment does not have Ruby/Bundler or libgettextpo headers installed on PATH.