Fix some problems with Postbank TAN media handling and statement fetching#26
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve Postbank compatibility by adjusting TAN media handling in HKTAN messages and aligning CAMT statement fetching (HKCAZ) with the library’s international account model, alongside some dependency/tooling updates.
Changes:
- Switch
HKCAZto useInternationalAccountGroupinstead of the removedCamtAccountGroup. - Centralize HKTAN
tanMediaselection logic inDialogviagetTanMediaName(). - Update dependencies (notably
vitest/fast-xml-parser) and add apnpm-workspace.yamlconfig entry.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/segments/HKCAZ.ts | Use InternationalAccountGroup for CAMT statement requests. |
| src/interactions/initDialogInteraction.ts | Make UPD account mapping resilient to missing HIUPD.account group. |
| src/dialog.ts | Centralize TAN media selection logic for HKTAN segment creation. |
| src/dataGroups/CamtAccount.ts | Remove obsolete CAMT account data group. |
| pnpm-workspace.yaml | Add pnpm build-allowlist config (but currently missing packages). |
| package.json | Bump fast-xml-parser, @types/node, vitest. |
| pnpm-lock.yaml | Lockfile updates reflecting dependency bumps and new transitive deps. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comment on lines
41
to
46
| "devDependencies": { | ||
| "@biomejs/biome": "2.3.10", | ||
| "@types/node": "^20.19.30", | ||
| "@types/node": "^20.19.41", | ||
| "typescript": "^5.9.3", | ||
| "vitest": "^4.0.17" | ||
| "vitest": "^4.1.8" | ||
| }, |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
Closes #25