fix: contact imports segments typing#222
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Fixes contact import segments typing to use objects instead of strings, matching the API. Small, isolated change with updated example and test.
Re-trigger cubic
gabrielmfern
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes contact import segments to accept an array of segment objects instead of string IDs, aligning with the API. Examples/tests updated and version bumped to
2.32.1.Bug Fixes
CreateParams.segmentsnow expects[{"id": "uuid"}]and is sent as-is; removed conversion from string IDs.Migration
segments=["60a2ac5e-0774-456e-817d-ebf40f6dba31"]tosegments=[{"id": "60a2ac5e-0774-456e-817d-ebf40f6dba31"}].Written for commit 57c35cb. Summary will update on new commits.