Skip to content

fix(agent): Reconcile principal redis volume correctly#1181

Closed
olivergondza wants to merge 2 commits into
redhat-developer:v1.21from
olivergondza:redis-principal-volume-hotfix
Closed

fix(agent): Reconcile principal redis volume correctly#1181
olivergondza wants to merge 2 commits into
redhat-developer:v1.21from
olivergondza:redis-principal-volume-hotfix

Conversation

@olivergondza

@olivergondza olivergondza commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

https://redhat.atlassian.net/browse/GITOPS-9982

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Bringing in argoproj-labs/argocd-operator@f8859ab...32440c2

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci Bot added the kind/bug Something isn't working label Jun 17, 2026
@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adamsaleh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 679daf73-3ad6-41cb-b6d7-03e56cfca872

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@anandf anandf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwest

jgwest commented Jun 17, 2026

Copy link
Copy Markdown
Member

/hold

@jgwest jgwest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.21 branch should consume commits from argocd-operator release-0.19 branch

(Also the title of this PR should describe its purpose)

Backport of argoproj-labs/argocd-operator#2235

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@olivergondza olivergondza force-pushed the redis-principal-volume-hotfix branch from 0940989 to 5bd02ef Compare June 17, 2026 11:45
@olivergondza olivergondza changed the title chore(deps): Fetch https://github.com/argoproj-labs/argocd-operator/p… fix(agent): Reconcile principal redis volume correctly Jun 17, 2026
@olivergondza

Copy link
Copy Markdown
Collaborator Author

Updated to pull in the backported branch only. PTAL

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

@olivergondza: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.21-e2e b134726 link true /test v4.21-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@svghadi

svghadi commented Jun 17, 2026

Copy link
Copy Markdown
Member

I just merged another PR to bump up the dependency. We can close this one. Thanks @olivergondza

@olivergondza

Copy link
Copy Markdown
Collaborator Author

Ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants