Enh/sleek 197 webui migration rdkit salt stripper#171
Closed
jannik-sem wants to merge 53 commits into
Closed
Conversation
SLEEK-114 (Create shared classes and auxiliary functions)
…tion SLEEK-114 (Create shared classes and auxiliary functions)
…flous imports from manifest SLEEK-114 (Create shared classes and auxiliary functions)
SLEEK-163 (WebUI-Migration RDKit Remove Hs)
SLEEK-160 (WebUI-Migration RDKit Add Hs)
SLEEK-162 (WebUI-Migration RDKit Aromatizer)
SLEEK-165 (WebUI-Migration RDKit Canonical SMILES)
SLEEK-166 (WebUI-Migration RDKit Kekulizer)
SLEEK-171 (WebUI-Migration RDKit Calculate Charges)
SLEEK-173 (WebUI-Migration RDKit Molecule Fragmenter)
SLEEK-186 (WebUI-Migration RDKit MCS)
* (no-ticket) Added result column auto guesser due to mui capability of opening node dialogs without input connections * (no-ticket) Abort auto guessing of result column name on empty input column
… opening node dialogs without input connections
SLEEK-179 (WebUI-Migration RDKit To Molecule)
SLEEK-187 (WebUI-Migration RDKit Molecule Highlighting)
SLEEK-205 (WebUI-Migration RDKit One Component Reaction)
SLEEK-206 (WebUI-Migration RDKit Two Component Reaction)
SLEEK-228 (WebUI-Migration RDKit R-Group Decomposition)
SLEEK-215 (WebUI-Migration RDKit Structure Normalizer)
SLEEK-177 (WebUI-Migration RDKit Find Murcko Scaffolds)
SLEEK-185 (WebUI-Migration RDKit Substructure Filter)
SLEEK-229 (WebUI-Migration RDKit Adjust Query Properties)
SLEEK-168 (WebUI-Migration RDKit Diversity Picker)
SLEEK-164 (WebUI-Migration RDKit Chemical Transformation)
SLEEK-184 (WebUI-Migration RDKit SDF Difference Checker)
SLEEK-161 (WebUI-Migration RDKit Generate Coords)
SLEEK-222 (WebUI-Migration RDKit Molecule to SVG)
SLEEK-235 (WebUI-Migration RDKit Descriptor Calculation)
SLEEK-172 (WebUI-Migration RDKit From IUPAC)
SLEEK-174 (WebUI-Migration RDKitSmilesHeaders)
SLEEK-181 (WebUI-Migration RDKit From InChI)
SLEEK-183 (WebUI-Migration RDKit Molecule Catalog Filter)
SLEEK-197 (WebUI-Migration RDKit Salt Stripper)
SLEEK-199 (WebUI-Migration RDKit Optimize Geometry)
SLEEK-202 (WebUI-Migration RDKit Fingerprint)
SLEEK-204 (WebUI-Migration RDKit Open 3D Alignment)
SLEEK-210 (WebUI Migration RDKit Molecule Extractor)
SLEEK-211 (WebUI Migration RDKit Molecule Substructur Filter)
SLEEK-212 (WebUI Migration RDKit Count-Based Fingerprint)
SLEEK-214 (WebUI-Migration RDKit From Molecule)
SLEEK-221 (WebUI-Migration RDKit To InChI)
SLEEK-221 (WebUI-Migration RDKit To InChI)
SLEEK-218 (WebUI-Migration RDKit Substructure Counter)
SLEEK-182 (WebUI-Migration RDKit RMSD Filter)
SLEEK-205 (WebUI-Migration RDKit One Component Reaction)
SLEEK-206 (WebUI-Migration RDKit Two Component Reaction)
SLEEK-176 (WebUI-Migration RDKit Fingerprint Reader and Writer)
SLEEK-176 (WebUI-Migration RDKit Fingerprint Reader and Writer)
…ies node SLEEK-229 (WebUI-Migration RDKit Adjust Query Properties)
The m_bHadSaltInputTable guard in configure() prevented the column name reset from running after the first configure call, so stale or incompatible column names were never cleared and auto-guess never re-ran. Removed the guard so the reset fires whenever the column is missing from the current spec. Also narrowed the WebUI salt column choices provider and auto-guesser to only show RDKit-mol-compatible types (RDKitMolValue, SDF, SMILES), matching what the NodeModel actually accepts. Previously they included SmartsValue via DEFAULT_CLASSES, which the NodeModel rejects, allowing the dialog to select a column that would always fail configure. SLEEK-197 (WebUI-Migration RDKit Salt Stripper)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs explicit autoguesser and not RDKitAutoguesser from util