Fix handling of AdhocReport response (#47)#48
Conversation
Not using XML directly any more. This can cause large reports to fail parsing. Removed comment that indicated we shouldn't be doing this ;-)
|
@gschneider-r7 this is in relation to #47 and fixes the error we're seeing. The bug was present already but only exposed through my PR #43. Now we're not using Tested the CSV component but not how an XML report is handled. However, the way the code changed there should not be any difference. |
|
I don't have time to test this myself currently, so if you need this merged and published I'll have to take your word for it that it works. 😉 Just let me know if you need me to push it out. The changes otherwise look fine to me. |
|
Yup, we're currently pinned to the dev commit in my repo and it keeps happily importing. Haven't seen any issues since we pushed out this fix. Thanks. |
Not using XML directly any more. This can cause large reports to fail
parsing. Removed comment that indicated we shouldn't be doing this ;-)
Types of changes