This repository was archived by the owner on May 14, 2021. It is now read-only.
Add support for ESO API#45
Open
fruechel wants to merge 11 commits into
Open
Conversation
This mirrors the changes in rapid7/nexpose-client#309 but limited to discovery connections.
Contributor
Author
|
I did just realise that the update to 6.4.66 actually pushed out some changes regarding the API. I'm looking at the |
The old value used was "Scheduling" which is not documented anywhere
("Schedule" is the documented value). The parsing function
(CreateFromXML) uses "Schedule" as that's what the server sends. This
makes the other direction (AsXML) consistent. The server accepts this
value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors the changes in rapid7/nexpose-client#309 but limited to
discovery connections.
Description
Implement support for ESO API for discovery connections. Based on @hwilson-r7's changes in rapid7/nexpose-client#309
EsoConfigurationclass to handle all types of configurationAWSConfigurationclass to address that particular use case.Looking for feedback on whether this is the way you'd like this implemented or if changes are needed.
Motivation and Context
This API is new and there is no support for it yet. We're looking at using it.
How Has This Been Tested?
I created a test script that runs through most functionality. The following things are known issues:
The following things have been tested and work:
A recent update does also seem to cause 401s unless
X-Requested-With: XMLHttpRequestHTTP headers are sent. This seems like a weird bug introduced in 6.4.66 so I didn't include it in the PR, assuming it'll go away once fixed there.No unit tests have been written.
This is the function used to test things:
Types of changes
Checklist: