Coerce FieldOrderedValuesTest NULL uniqueness failures#1390
Merged
Conversation
Copilot
AI
changed the title
Coerce FieldOrderedValuesTest tests for SQL Server NULL uniqueness
Coerce FieldOrderedValuesTest NULL uniqueness failures
Jun 13, 2026
Copilot created this pull request from a session on behalf of
aidanharan
June 13, 2026 14:02
View session
aidanharan
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL Server treats NULLs in unique indexes as equal, unlike PostgreSQL/MySQL/SQLite. Three
FieldOrderedValuesTesttests insert rows with NULLauthor_id/name, hitting a duplicate key error onindex_books_on_author_id_and_name.Changes
test/cases/coerced_tests.rb— adds coerce wrappers for three tests that were not yet handled:test_in_order_of_with_out_of_bound_integer_does_not_match_nullstest_in_order_of_with_only_unrepresentable_values_does_not_build_empty_casetest_in_order_of_with_unknown_enum_key_does_not_match_nullsEach coercion follows the existing pattern in
FieldOrderedValuesTest: drop the unique index before the test, run the original, then restore the index inensure.