gh-151059: Use PyObject_CallMethodOneArg in datetime call_tzinfo_method#151062
Merged
Conversation
…o_method Call tzinfo.utcoffset()/dst() via PyObject_CallMethodOneArg with the interned &_Py_ID(utcoffset)/&_Py_ID(dst) names instead of PyObject_CallMethod(name, "O", arg), matching call_tzname() in the same file. Drops the format-string parse, the temporary tuple, and the per-call method-name string. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
eendebakpt
changed the title
sobolevn
approved these changes
Jun 8, 2026
Member
|
I wanted to give Paul a few days in case he wants to comment, but this is a small change so there's not much to discuss ;-) |
Contributor
Author
Yes, many. But most not with the same obvious performance impact. I can create a mechanical change for them, but it might be rejected as churn. |
Member
|
Please, provide perf metrics, so we can decide :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See corresponding issue for details.
PyObject_CallMethodOneArgin datetimecall_tzinfo_method#151059