gh-150932: Add a partial-line-marker on Apple system logger and optimize the iOS testbed runner#150983
Closed
timrid wants to merge 2 commits into
Closed
gh-150932: Add a partial-line-marker on Apple system logger and optimize the iOS testbed runner#150983timrid wants to merge 2 commits into
timrid wants to merge 2 commits into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
|
Thanks for the PR; however, I'm going to close this on the basis that the discussion on the underlying ticket hasn't yet concluded that either of these ideas are desirable. Of the two, the ANSI reversal is a firm "no" from me. I'm not yet convinced the line-end thing is worthwhile either; but if I am convinced, it will need to be extracted from the ANSI reversal stuff, so a clean PR would make sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a marker for partial lines on the Apple system logger, so that a cooperating log reader (like the iOS testbed runner) can re-join them instead of rendering each flush as a separate line in the Apple system log.
Additionally, this optimizes the iOS testbed runner by:
Fixes #150932
To test this, I used this test script and ran it in an iOS testbed: