Fix new-tab behaviour on examples page GitHub link#1937
Open
summerscope wants to merge 1 commit into
Open
Conversation
The {:target="_blank"} attr_list syntax renders correctly in the
mkdocs preview but does not produce target=_blank in production,
matching the issue fixed for compliance.md. Switch to a raw <a>
tag, which works reliably in both pipelines.
Deploying logfire-docs with
|
| Latest commit: |
9dfa831
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72eec597.logfire-docs.pages.dev |
| Branch Preview URL: | https://claude-fix-examples-external.logfire-docs.pages.dev |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-up to #1936. The "View on GitHub" link in
docs/reference/examples.mduses the{:target="_blank"}attr_list syntax, which (as confirmed by manual testing on the live docs) doesn't actually produce a new-tab link in production — same pipeline issue as the compliance page. Switching it to a raw<a target="_blank" rel="noopener">tag, which works reliably.Test plan
/docs/logfire/reference/examples/opens in a new tab.Generated by Claude Code