Skip to content

Fix wrong reference on irradiance.reindl#2776

Open
cbcrespo wants to merge 2 commits into
pvlib:mainfrom
cbcrespo:reindl-references
Open

Fix wrong reference on irradiance.reindl#2776
cbcrespo wants to merge 2 commits into
pvlib:mainfrom
cbcrespo:reindl-references

Conversation

@cbcrespo

@cbcrespo cbcrespo commented Jun 9, 2026

Copy link
Copy Markdown

Fixes the wrong reference in the irradiance.reindl docstrings, previously identified in #2765.

@ramaroesilva

Copy link
Copy Markdown
Contributor

Never reviewed a PR before, but seems good to me :-)

@echedey-ls echedey-ls added bug documentation GSoC Contributions related to Google Summer of Code. labels Jun 9, 2026
@echedey-ls echedey-ls added this to the v0.15.2 milestone Jun 9, 2026
@AdamRJensen

Copy link
Copy Markdown
Member

@cbcrespo congrats with opening your first PR!

You'll notice that the "Python Flake8 Linter" is marked as red and with an x. If you click this, you can see the details which the linter is unhappy about (it's about good practice formatting).

While pvlib is not very consistent, we made a choice a while ago to use the IEEE citation format. You can read more about this here. Could you update the existing citations to match the IEEE format?

@cwhanse

cwhanse commented Jun 10, 2026

Copy link
Copy Markdown
Member

@cbrespo

For future PRs, please include the checkboxes in the template that's automatically added in the PR description. We use those to manage the review work. You can strikethrough those that don't apply using "~~" on both ends, like this:

  • [ ] doesn't matter

@cbcrespo cbcrespo force-pushed the reindl-references branch from a13e5ed to 136ed6b Compare June 11, 2026 11:50
@cbcrespo

Copy link
Copy Markdown
Author

Thanks for the tips @AdamRJensen and @cwhanse.

I think I've fixed the problem now, and I've also changed the reference style to IEEE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug documentation GSoC Contributions related to Google Summer of Code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Likely wrong reference on irradiance.reindl

5 participants