fix(desktop): open Settings as an overlay so it doesn't end the session#26
Merged
Merged
Conversation
Settings was a sibling route under AppLayout, so navigating to it unmounted
HomePage — which ran CapturePreview's unmount cleanup (stopHosting), dropping
the host from the LiveKit room and ending the live session (and restarting
egress, which traps YouTube on "Preparing"). Coming back landed on a fresh
HomePage with no session.
Settings now renders as a full-screen overlay (new useUIStore) over the still
-mounted Home, so the session keeps running underneath. All entry points are
covered: the main-process menu/tray IPC ('navigate' -> '/settings') is
intercepted in main.tsx, the mac/win TitleBar button opens the overlay, and
the Back button closes it. The unmounting '/settings' route is removed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In an active session, opening Settings and coming back closed the session.
Settings was a sibling route under
AppLayout, sonavigate('/settings')unmountedHomePage→ which ranCapturePreview's unmount cleanup (stopHosting) → dropped the host from the LiveKit room and ended the session (also restarting egress, which traps YouTube on "Preparing"). Returning landed on a freshHomePagewith no session.Fix
Settings now renders as a full-screen overlay (new
useUIStore) over the still-mounted Home, so the session keeps running underneath. All entry points covered:'navigate' -> '/settings') intercepted inmain.tsx(this is the Linux path — TitleBar is null on Linux)The unmounting
/settingsroute is removed; the overlay is scoped to the content area so the custom title bar stays usable.Tests
useUIStoreopen/close;AppLayoutkeeps children mounted and toggles the overlay. Full desktop suite green (472 tests).🤖 Generated with Claude Code