Update cookie sync to use bidder name instead of cookie family#4464
Open
Lightwood13 wants to merge 7 commits into
Open
Update cookie sync to use bidder name instead of cookie family#4464Lightwood13 wants to merge 7 commits into
Lightwood13 wants to merge 7 commits into
Conversation
Lightwood13
force-pushed
the
update-cookie-sync-to-use-bidder-name-instead-of-cookie-family
branch
from
ab59133 to
522d1c8
Compare
…r-name-instead-of-cookie-family
…r-name-instead-of-cookie-family
…ead-of-cookie-family # Conflicts: # src/main/java/org/prebid/server/spring/config/bidder/TaboolaConfiguration.java
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| final String body; | ||
| switch (error) { | ||
| case InvalidRequestException invalidRequestException -> { | ||
| case InvalidRequestException ignored -> { |
| body = "Invalid request format: " + message; | ||
| } | ||
| case UnauthorizedUidsException unauthorizedUidsException -> { | ||
| case UnauthorizedUidsException ignored -> { |
| body = "Unauthorized: " + message; | ||
| } | ||
| case UnavailableForLegalReasonsException unavailableForLegalReasonsException -> { | ||
| case UnavailableForLegalReasonsException ignored -> { |
| body = "Unavailable For Legal Reasons."; | ||
| } | ||
| case InvalidAccountConfigException invalidAccountConfigException -> { | ||
| case InvalidAccountConfigException ignored -> { |
Lightwood13
force-pushed
the
update-cookie-sync-to-use-bidder-name-instead-of-cookie-family
branch
from
df57b22 to
75acdfd
Compare
CTMBNara
requested changes
Jun 16, 2026
Comment on lines
+17
to
+34
| private static final String CALLBACK_URL_TEMPLATE = """ | ||
| %s/setuid?\ | ||
| bidder=%s\ | ||
| &gdpr={{gdpr}}\ | ||
| &gdpr_consent={{gdpr_consent}}\ | ||
| &us_privacy={{us_privacy}}\ | ||
| &gpp={{gpp}}\ | ||
| &gpp_sid={{gpp_sid}}\ | ||
| &f={{format}}\ | ||
| &uid=%s"""; | ||
|
|
||
| private static final String GDPR_PLACEHOLDER = "{{gdpr}}"; | ||
| private static final String GDPR_CONSENT_PLACEHOLDER = "{{gdpr_consent}}"; | ||
| private static final String US_PRIVACY_PLACEHOLDER = "{{us_privacy}}"; | ||
| private static final String GPP_PLACEHOLDER = "{{gpp}}"; | ||
| private static final String GPP_SID_PLACEHOLDER = "{{gpp_sid}}"; | ||
| private static final String REDIRECT_URL_PLACEHOLDER = "{{redirect_url}}"; | ||
| private static final String FORMAT_PLACEHOLDER = "{{format}}"; |
Comment on lines
+119
to
+123
| @Value(staticConstructor = "of") | ||
| private static class UsersyncUrls { | ||
| String usersyncUrl; | ||
| String redirectUrl; | ||
| } |
| biddersWithDuplicateCookieFamilyName.add(bidder); | ||
| } | ||
| } | ||
| final Set<String> biddersOverLimit = new HashSet<>(IteratorUtils.toList(biddersIterator)); |
Collaborator
There was a problem hiding this comment.
StreamUtil.asStream(biddersIterator).toSet()
Comment on lines
+120
to
+121
| .collect(Collectors.toMap(Function.identity(), | ||
| bidder -> bidderCatalog.usersyncerByName(bidder).orElseThrow())); |
| } | ||
|
|
||
| @Bean | ||
| UsersyncInfoFactory usersyncInfoBuilder(@Value("${external-url}") String externalUrl) { |
| .extracting(CookieSyncContext::getBiddersContext) | ||
| .extracting(BiddersContext::allowedBidders) | ||
| .asInstanceOf(InstanceOfAssertFactories.COLLECTION) | ||
| .hasSize(1); |
Collaborator
There was a problem hiding this comment.
containsExactly
Also, check for rejected entries
| .extracting(CookieSyncContext::getBiddersContext) | ||
| .extracting(BiddersContext::rejectedBidders) | ||
| .isEqualTo(Map.of("requested-bidder", RejectionReason.DISALLOWED_ACTIVITY)); | ||
| .isEqualTo(Map.of("coop-sync-bidder", RejectionReason.OVER_LIMIT)); |
Collaborator
There was a problem hiding this comment.
Also, check for requested-bidder
| .extracting(CookieSyncContext::getBiddersContext) | ||
| .extracting(BiddersContext::allowedBidders) | ||
| .asInstanceOf(InstanceOfAssertFactories.set(String.class)) | ||
| .containsExactly("coop-sync-bidder"); |
| .unwrap() | ||
| .extracting(CookieSyncContext::getBiddersContext) | ||
| .extracting(BiddersContext::rejectedBidders) | ||
| .isEqualTo(Map.of("coop-sync-bidder", RejectionReason.DUPLICATE_COOKIE_FAMILY_NAME)); |
| .unwrap() | ||
| .extracting(CookieSyncContext::getBiddersContext) | ||
| .extracting(BiddersContext::rejectedBidders) | ||
| .isEqualTo(Map.of("requested-bidder", RejectionReason.DISALLOWED_ACTIVITY)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of https://github.com/prebid/prebid-server/pull/2948/changes
/cookie_syncendpoint to return bidder name instead of cookie family name in the redirect url./setuidendpoint to accept bidder name instead of cookie family name.