Housekeeping: Bump to Java 25 and Spring Boot 3.5#191
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
| schedule: | ||
| - cron: '0 3 * * 1' |
There was a problem hiding this comment.
We made the same thing for PBS so that scan periodically triggers on schedule in master branch too. Notifications from such scans go into the Security section on GitHub. At least they should go, although I never saw any.
| Optional.ofNullable(properties.getRedis()) | ||
| .map(redis -> | ||
| redis.entrySet() | ||
| .stream() | ||
| .collect(Collectors.toMap( | ||
| Map.Entry::getKey, | ||
| entry -> getReactiveRepository(entry.getValue())))) | ||
| .orElse(Map.of()); |
There was a problem hiding this comment.
This one has been unhandled on purpose. Since Module-storage endpoint is unconditional - you should have configuration (at least empty one, which is provided in default spring profile in application.yml). So I don't see a reason why we should change this behavior. Please, revert.
There was a problem hiding this comment.
Spring Boot 3.5 resolves this config redis: {} as null. Which makes old code throw NPE.
3 participants
No description provided.