test: migrate golden tests to golden_matrix and cover all custom widgets#1
Open
Autocrab wants to merge 2 commits into
Open
test: migrate golden tests to golden_matrix and cover all custom widgets#1Autocrab wants to merge 2 commits into
Autocrab wants to merge 2 commits into
Conversation
Author
|
Comment: Goldens generated on MacOS, so if you work on Ubuntu\Windows then u should regenerate them locally. AFAIK there are no golden tests checks on CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
It rewrites the golden tests for the Auris custom widgets. Now the tests use the
golden_matrixpackage, cover both light and dark themes, and include all 14 widgets.Added
golden_matrix: 1.1.1as a dev dependency (pinned to the exact version, no ^).AurisDataRow,AurisNotification,AurisHexOrnament,AurisScanBracket,AurisTerminal.AurisPanel(accent / plain),AurisProgressBar(mid / full) andAurisStatCard(positive / negative delta).Changed
test/golden/goldens/, split by widget and scenario (for exampleaurisbadge/variants/dark_en_ltr_1x.png). This keeps them separate from the unit tests and their files.AurisTheme.dark()andAurisTheme.light(). This closes the gap where light was never tested. In total there are now 40 baseline images (20 scenarios × 2 themes).Removed
test/auris_golden_test.dartfile.test/goldens/(9 PNG files). They are replaced by the new folder layout.