fix(config): use provider type in unsupported provider error messages#6937
Open
kunal-yelgate wants to merge 2 commits into
Open
fix(config): use provider type in unsupported provider error messages#6937kunal-yelgate wants to merge 2 commits into
kunal-yelgate wants to merge 2 commits into
Conversation
Signed-off-by: kunal_yelgate <kunalyelgatew@gmail.com>
kunal-yelgate
force-pushed
the
fix/type-unsupported
branch
from
1aed7e3 to
3691e5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes incorrect error messages in
PipedPlatformProvider.MarshalJSON()andPipedAnalysisProvider.MarshalJSON()by reporting the unsupported providerTypeinstead of the providerNamewhen an invalid provider type is encountered.Why we need it:
The current error messages can be misleading because they display the provider name rather than the actual invalid type value. This makes configuration issues harder to diagnose and debug. Reporting the unsupported type provides more accurate and actionable feedback to users.
Which issue(s) this PR fixes:
Fixes #6931
Does this PR introduce a user-facing change?:
How are users affected by this change:
Error messages for unsupported platform and analysis provider types now correctly display the invalid provider type value.
Example:
unsupported platform provider type: my-providerunsupported platform provider type: UNKNOWN_TYPEIs this breaking change:
How to migrate (if breaking change):