Use idiomatic Effect primitives for websocket reconnects#3047
Draft
cursor[bot] wants to merge 2 commits into
Draft
Use idiomatic Effect primitives for websocket reconnects#3047cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Contributor
|
🚀 Expo continuous deployment is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
effect/Durationand retry exhaustion withOption.JSON.parsecheck with aSchema.fromJsonStringtagged decoder.@effect/vitestwithassert.Why
This keeps the reconnect policy closer to Effect primitives end-to-end, makes absence explicit with
Option, and gives heartbeat parsing typed schema validation while preserving existing runtime behavior.UI Changes
Not applicable; no user-facing UI rendering changed.
Checklist
Validation:
pnpm exec vp run --filter @t3tools/client-runtime test -- --run src/reconnectBackoff.test.ts src/wsTransport.test.ts(24 files, 180 tests passed)pnpm exec vp check(passed; existing lint warnings only)pnpm exec vp run typecheck(passed; existing suggestion outside this change remains)Note
Replace millisecond primitives with Effect
DurationandOptiontypes in websocket reconnect backoffReconnectBackoffConfigin reconnectBackoff.ts to useDuration.Inputfor delay fields andOption<number>formaxRetriesinstead of raw numbers andnull.getReconnectDelayfunction returningOption<Duration>, withgetReconnectDelayMskept as a compatibility wrapper returning milliseconds ornull.Option/Durationbackoff API and replaces manual JSON pong detection with a schema-based decoder.Durationconversion andOption.getOrThrow.DEFAULT_RECONNECT_BACKOFF.maxRetriesisOption.none, module evaluation inwsConnectionState.tswill now throw rather than silently produceundefined.Macroscope summarized cd89779.