Skip to content

Beginnings of new parser port#1102

Draft
sgrif wants to merge 2 commits into
mainfrom
sg-new-parser
Draft

Beginnings of new parser port#1102
sgrif wants to merge 2 commits into
mainfrom
sg-new-parser

Conversation

@sgrif

@sgrif sgrif commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

WIP, does not yet handle advisory locks with values clauses. Please see individual commits for more details

sgrif added 2 commits June 23, 2026 11:24
We're having to deparse and reparse because I want to be able to move
individual functions over without porting the whole codebase at once. If
I parsed the original SQL string directly I'd need to also port
everything in the rewriter immediately.

This has to live at the AST level, because the memory context lives on
`ParseResult` so anything lower would have to be a self referential
struct
The actual ported code is relatively simple, using that code with
conditional compilation is not
@sgrif sgrif requested a review from levkk June 23, 2026 22:59
Comment thread pgdog/src/frontend/router/parser/cache/ast.rs
@levkk

levkk commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Uber cool

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.35036% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/frontend/router/parser/statement.rs 95.90% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@levkk

levkk commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants