feat: block cross-shard sharding key updates with ON DELETE#1100
Open
murex971 wants to merge 2 commits into
Open
feat: block cross-shard sharding key updates with ON DELETE#1100murex971 wants to merge 2 commits into
murex971 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
levkk
reviewed
Jun 23, 2026
| self.insert.table.as_ref().map(Table::from) | ||
| } | ||
|
|
||
| pub(crate) fn sharded_table<'a>( |
Collaborator
There was a problem hiding this comment.
I feel like this logic is duplicated, but I could be wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Block cross-shard sharding key updates when the row is referenced by a foreign key with a destructive
ON DELETEaction (CASCADE,SET NULL, orSET DEFAULT). Those moves are implemented asDELETE + INSERT, so the delete step could silently affect related rows. PgDog now checks loaded schema metadata before the delete/insert and returns a recoverable error; same-shard updates andON DELETE RESTRICT / NO ACTIONare unchanged.Testing
Related issues/comments
closes #899