Fix PMBus backend selector#703
Open
mkeeter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(There's a new big block comment that explains what's going on, so you may want to go read that)
Previously, we would always select the
IdolWorkerPMBus agent when network connected. This is fine for theudprpcbackend, where the HIF program is executed on the host computer and so the additional overhead of Idol IPC doesn't matter.However, the introduction of the
hiffy+netbackend means that we would (1) select theIdolWorkeragent, because the system is network-connected then (2) use thehiffybackend, executing the larger programs on the SP. This is not ideal!This PR teaches the
pmbuscrate about the differentHiffyContextbackends, so that it can make smarter choices.