Clamp FLASH size to 8K to match Hubris#63
Open
mkeeter wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Apparently Linux has different opinions on the resulting binary size versus MacOS (where a debug build works fine) 🫠 Here's the debug build size on my machine, which just barely squeezes under the line: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash of
target/thumbv8m.main-none-eabihf/release/bootlebydoesn't change, so this should be innocuous (but prevents us from being Unpleasantly Surprised further down the line)