Apply Benchmark patch only where its needed#2798
Conversation
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE Baseline scrutiny: established OpenTensor-associated contributor with repo write permission; no trusted-list Gittensor match found; branch apply-benchmark-to-only-bad-benches -> devnet-ready. Reviewed the cached PR metadata, prior Skeptic comment, contributor signals, comments, and full diff. The PR does not modify The runtime-facing changes are generated weight updates plus a required FindingsNo findings. ConclusionNo malicious intent or security vulnerability was found in the reviewed diff. Residual risk is limited to benchmark-tooling correctness and generated-weight accuracy, which do not cross the Skeptic security threshold here. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor UNKNOWN; author is an established repository contributor with write permission, so review focused on benchmark tooling correctness rather than intent. PR body is substantive enough to leave unchanged. Overlap check: the overlapping open PRs touch common runtime/generated-weight files, but their titles and bases indicate unrelated runtime features or broad wiring work rather than this benchmark patch-generation behavior. I do not see duplicate work to recommend closing. Spec version: bumped from Validation: FindingsNo findings. ConclusionThe PR keeps the benchmark patch path scoped to drifted benchmark functions and updates the comparator so total weight drift is evaluated over benchmark component ranges. I did not find a domain correctness issue that should block merge. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Description
This PR modifies the benchmark flow so that only extrinsics that have drifted passed the threshold or have incorrect read/writes are updated rather than replacing the entire file and creating conflicts everywhere.
Also fixes a bug where it would fail extrinsics where it shouldn't.