add 3 more Ink interface#2797
Conversation
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE LOW/BASELINE scrutiny: open-junius has repo write permission, substantial prior contribution history, no committer mismatch except the expected subtensor-ai-review bot auto-fix commit, and no Gittensor allowlist match found; branch add-tests-for-new-query -> devnet-ready. Static-only Skeptic review found the diff limited to Ink contract metadata, an updated WASM test artifact, and three added zombienet EVM contract tests for read-only query messages. No FindingsNo findings. ConclusionNo malicious intent or security vulnerability found in the changed surface. Remaining risk is ordinary binary test-artifact review risk for the updated WASM, with no concrete security issue identified. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor: UNKNOWN; author has repo write permission and substantial prior contribution history. No overlapping PRs were prefetched. The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it. This PR is limited to the Ink contract artifact/metadata and the zombienet EVM wasm-contract test suite. The updated No runtime or pallet code changed, so no spec-version bump is required. Verification performed: FindingsNo findings. ConclusionApproved. The PR adds focused EVM/Ink coverage for the new query interfaces without changing on-chain behavior, and I found no domain issue blocking merge. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Description
Follow the PR #2768, update the Ink contract in ts-tests and verify all 3 new query functions.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.