Fix contract tests balance checks + benchmarks#2783
Conversation
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: l0r1s is an established write-permission contributor with substantial prior subtensor PR history; branch is tx-ext-refactor-followup -> devnet-ready. Reviewed the prefetched PR metadata, prior Skeptic comment, contributor signals, changed-file list, and full patch. The PR only relaxes two balance-smoke thresholds in FindingsNo findings. ConclusionNo malicious behavior or security vulnerability is apparent from this test-only diff. The loosened assertions do not alter chain/runtime behavior or introduce a supply-chain or CI execution path. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor UNKNOWN; author is an established write-permission contributor with substantial prior subtensor history, so review focused on correctness of the test-only diff. PR body was empty/trivial; the Auditor has auto-filled it. Please review. No domain findings. This PR only relaxes two balance-smoke tolerances in Overlap check: PR #2716 also touches this file, but as part of a broader contract E2E migration that deletes FindingsNo findings. ConclusionThe change is limited to contract-test assertions and does not affect chain behavior. No blocking correctness, migration, weight, origin, or spec-version issues were found. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Motivation
PR #2773 changed transaction extension behavior, which shifted the fees observed by the crowdloan precompile E2E balance smoke tests. The existing assertions used a
1_000_000tolerance and now fail despite the intended balance flow still being preserved.What Changed
contract-tests/test/crowdloan.precompile.test.tsfrom1_000_000to2_000_000in both affected crowdloan precompile smoke paths.Behavioral Impact
This is a test-only change. It does not alter runtime behavior, pallet logic, transaction extensions, precompile code, dependencies, or production configuration.
Migration / Spec Version
No runtime or pallet code is changed, so no storage migration or
spec_versionbump is required.Testing
Validation is expected through the existing contract E2E test workflow that runs
contract-tests/test/crowdloan.precompile.test.ts.