Update registry.access.redhat.com/ubi9/go-toolset Docker tag to v1.26.3-1781070142#220
Conversation
….3-1781070142 Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Dockerfile's multi-stage builder Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Supply chain surface — verify before merge. This is a build-time base image substitution (CWE-829: Inclusion of Functionality from Untrusted Control Sphere). Confirm the following before merging:
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Line 1: The BASE_IMAGE argument uses a floating `:latest` tag instead of being
pinned to a specific digest, which violates container hardening guidelines and
increases supply-chain attack surface. Replace the `:latest` tag in the ARG
BASE_IMAGE definition with a specific digest in the format `@sha256`:... (for
example, registry.access.redhat.com/ubi9-micro@sha256:...). This single change
will automatically apply to all references of ${BASE_IMAGE}, including the FROM
statement that uses it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 90f2a0eb-ff29-4201-b163-e022f4c1770a
📒 Files selected for processing (1)
Dockerfile
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift-hyperfleet/architecture(manual)openshift-hyperfleet/hyperfleet-api(manual)openshift-hyperfleet/hyperfleet-sentinel(manual)openshift-hyperfleet/hyperfleet-adapter(manual)openshift-hyperfleet/hyperfleet-broker(manual)
| @@ -1,6 +1,6 @@ | |||
| ARG BASE_IMAGE=registry.access.redhat.com/ubi9-micro:latest | |||
There was a problem hiding this comment.
Pre-existing: Runtime base image not digest-pinned (CWE-250).
Line 1 defines ARG BASE_IMAGE=registry.access.redhat.com/ubi9-micro:latest (using :latest tag). Line 39 references it in FROM ${BASE_IMAGE}. Per container hardening guidelines, base images must be pinned by digest (@sha256:...), not floating tags. This violates CWE-250 and increases supply-chain attack surface. Not caused by this PR, but should be addressed before merge.
Also applies to: 39-39
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Dockerfile` at line 1, The BASE_IMAGE argument uses a floating `:latest` tag
instead of being pinned to a specific digest, which violates container hardening
guidelines and increases supply-chain attack surface. Replace the `:latest` tag
in the ARG BASE_IMAGE definition with a specific digest in the format
`@sha256`:... (for example, registry.access.redhat.com/ubi9-micro@sha256:...).
This single change will automatically apply to all references of ${BASE_IMAGE},
including the FROM statement that uses it.
Source: Coding guidelines
This PR contains the following updates:
1.26.2-1779959429→1.26.3-1781070142Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.