Skip to content

feat: add additional fields that are passed on to mkShell to support …#18

Merged
trevex merged 1 commit into
mainfrom
feat/add-mkshell-env
Jun 10, 2026
Merged

feat: add additional fields that are passed on to mkShell to support …#18
trevex merged 1 commit into
mainfrom
feat/add-mkshell-env

Conversation

@trevex

@trevex trevex commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

…env among others

What

Additional fields that are inherited by mkShell.

Why

Required for UI prototype of solar.

Testing

Notes for reviewers

Checklist

  • Tests added/updated
  • No breaking changes (or upgrade path documented above)
  • Readable commit history (squashed and cleaned up as desired)
  • AI code review considered and comments resolved

Summary by CodeRabbit

  • Chores
    • Enhanced development environment configuration to support additional customization options, including custom names, input dependencies, and environment variables in the shell setup.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ea3c60d6-82b8-45cc-93bf-7190f8cf49cb

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe7728 and c40663e.

📒 Files selected for processing (1)
  • flake.nix

📝 Walkthrough

Walkthrough

The self.lib.mkShell helper function in flake.nix is enhanced to accept three new optional parameters—name, inputsFrom, and env—with appropriate defaults, and forwards them to the underlying pkgs.mkShell derivation via inherit.

Changes

mkShell Parameter Enhancement

Layer / File(s) Summary
mkShell signature and parameter forwarding
flake.nix
self.lib.mkShell function signature adds three parameters: name (defaults to "dev-shell"), inputsFrom (defaults to []), and env (defaults to {}). These parameters are forwarded to pkgs.mkShell via inherit name env inputsFrom.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A Nix shell grows with grace,
Three parameters find their place,
Name, inputs, and env too,
Dev environments—now more true! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is partially related to the changeset—it mentions adding additional fields to mkShell but is incomplete (ends with 'to support …'), making it unclear what specific purpose these fields serve. Complete the title to clearly specify what the new fields support, e.g., 'feat: add name, inputsFrom, and env parameters to mkShell'
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers all required template sections (What, Why, Testing, Notes, Checklist) but lacks specific testing details and no issue reference is included.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-mkshell-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trevex trevex merged commit 5107b50 into main Jun 10, 2026
7 checks passed
@trevex trevex deleted the feat/add-mkshell-env branch June 10, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants