[CODE HEALTH] Move context propagation test classes into anonymous namespace#4200
Open
mateenali66 wants to merge 2 commits into
Open
Conversation
…mespace Resolves the misc-use-internal-linkage clang-tidy warnings for the TextMapCarrierTest, CompositePropagatorTest and EnvironmentCarrierTest classes in the context propagation tests by giving them internal linkage. Part of open-telemetry#4196. Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4200 +/- ##
=======================================
Coverage 82.89% 82.89%
=======================================
Files 405 405
Lines 17292 17292
=======================================
Hits 14332 14332
Misses 2960 2960 🚀 New features to boost your workflow:
|
dbarker
approved these changes
Jun 30, 2026
dbarker
left a comment
dbarker
left a comment
Member
There was a problem hiding this comment.
Thanks! Feel free to group these into larger PRs if working on the same clang-tidy warning category issue. This can help the reviews and merges proceed smoothly due to conflicts on the limits and changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
TextMapCarrierTest,CompositePropagatorTestandEnvironmentCarrierTestclasses in the context propagation tests into an anonymous namespace, resolving theirmisc-use-internal-linkageclang-tidy warnings. Test-only, no behavior change.Lowered the clang-tidy
warning_limitby 3 for both ABI presets accordingly.Part of #4196.