[CONFIGURATION] Apply default sampler when none is specified#4170
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4170 +/- ##
==========================================
+ Coverage 82.88% 82.90% +0.03%
==========================================
Files 405 405
Lines 17287 17292 +5
==========================================
+ Hits 14326 14334 +8
+ Misses 2961 2958 -3
🚀 New features to boost your workflow:
|
07322f1 to
a75d53a
Compare
|
I think there is one remaining default-sampler edge case. This PR handles the case where sampler:
parent_based:still leaves The config spec says |
Good catch! Updated the parser to apply the |
marcalff
left a comment
There was a problem hiding this comment.
LGTM, see a minor comment on the tests.
Fixes #4034
Changes
PR to apply default sampler when one is not set in the trace provider configuration. Updated the parser to apply
ParentBasedSamplerConfigurationwithAlwaysOnSamplerConfigurationas per the spec when no sampler is specified.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes