fix(app-shell): probed package publish from the banner + working New-chat button#1638
Merged
Conversation
…tually starts a new conversation Two leftovers from the 2026-06-11 staging E2E: 1. Pending-drafts banner (HomePage) now groups drafts by packageId and publishes each package via POST /packages/:id/publish-drafts — the governed path that orders structure-before-seeds server-side and runs the ADR-0038 L3 runtime probes. Probe findings + seed errors surface as a loud warning toast (and a verified-rows success toast otherwise), so the banner can no longer say 'Published!' over a silently-empty app (the gym_management incident: mid-publish container crash ate every seed row; the per-ref path had nothing checking). Package-less drafts keep the legacy by-reference fallback so they still publish. 2. The sidebar's New button was a no-op: it navigated to /ai, where the conversation hook's resolved-once guard kept the current id and the URL-mirroring effect immediately rewrote /ai back to /ai/:currentId. New now navigates to /ai?new=1; useChatConversation takes forceNew, which skips the guard + cache, clears the stale id synchronously (so the mirror can't bounce), and creates a fresh conversation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the two UI leftovers from the 2026-06-11 BVL staging E2E.
1. Pending-drafts banner → probed publish path
The Home banner published every draft by reference — no ADR-0038 L3 probes anywhere on that path. In the staging test, a mid-publish container crash ate every seed row of
gym_managementand the banner still toasted Published! over an app whose dashboard was all zeros.Now: drafts are grouped by
packageIdand each package goes throughPOST /packages/:id/publish-drafts(framework#1715's probed + seed-ordered path). Probe findings reusepublishHealthFromResponsefrom #1637:Package-less drafts keep the legacy by-ref fallback (structure first, seeds last) so they never dead-end.
2. New-chat button was a no-op
Newnavigated to/ai;useChatConversation's resolved-once guard kept the current id and the URL-mirror effect bounced straight back to/ai/:currentId. Confirmed live on staging — every message landed in the same conversation, and the granular-precedent context steered later builds away fromapply_blueprint.Now:
New→/ai?new=1; the hook's newforceNewoption skips the guard + cache, clears the stale id synchronously (so the mirror effect can't bounce while the create is in flight), and creates a fresh conversation. Flag self-strips when the fresh id is mirrored into the URL.Tests
useChatConversationcases: fresh-create skips cache, mid-mountforceNewflip overrides the guard, explicitactiveIdwins overforceNew🤖 Generated with Claude Code