feat(app-shell): render the map node in the flow designer#1633
Merged
Conversation
The framework's new `map` node (sequential batch approval, ADR-0037 A2) showed in the designer with the generic fallback icon — the server-driven palette picked it up (label + description from the engine descriptor) but the static icon/tone/category map had no `map` case. - flow-canvas-parts: `map` → ListChecks icon, loop/sky tone, Logic category (consistent with loop/parallel/try_catch). - flow-node-config: a `map` inspector group (collection / per-item flow / item variable / item object / output variable) + `map` in the type picker, so the property panel renders a form instead of falling back to JSON. Browser-verified against showcase_release_signoff: the map node renders with the list-checks icon + sky tone, appears under Logic in the add-node palette, and the Runs panel shows the sequential re-entries (signoffs MAP ×3). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The framework's new
mapnode (sequential batch approval, ADR-0037 A2 — framework #1709) rendered in the Studio flow designer with the generic fallback icon. The server-driven palette already picked it up (label + description from the engine action descriptor), but the static icon/tone/category map inflow-canvas-parts.tsxhad nomapcase, and the inspector had no config group.flow-canvas-parts:map→ListChecksicon, loop/sky tone, Logic category (consistent with loop / parallel / try_catch).flow-node-config: amapinspector group (collection / per-item flow / item variable / item object / output variable) +mapin the type picker, so the property panel renders a form instead of falling back to JSON.Test plan
showcase_release_signoff: the map node renders with thelist-checksicon + sky tone (lucide-list-checks text-sky-600), appears under Logic in the add-node palette with the engine description, and the Runs panel shows the sequential re-entries (signoffs MAP×3 in one completed run).pnpm vitest runmetadata-admin previews: 96 green. (The two pre-existing app-shell type-check errors are in unrelated AI/chatbot files, not these.)🤖 Generated with Claude Code