test(automation)+showcase: nested control-flow composition#1716
Merged
Conversation
Single-construct tests cover loop/parallel/try_catch in isolation; nothing exercised their INTERACTIONS when nested. Adds both the deterministic proof and a worked composite example. Engine tests (nested-composition.test.ts, +3): - parallel INSIDE loop: the loop iterator is visible to a node in a nested parallel branch (scope flows in); step folding tags each step with its INNERMOST container (leaf → parallel-branch/inner_par; the parallel node → loop-body/outer_loop); the after-block continuation runs once. - loop INSIDE try_catch: deepest step folds to the loop, the loop folds to the try region. - a mutation made deep inside nested regions is visible to the after-block (regions run in the enclosing scope; last iteration wins). Showcase (showcase_project_escalation): on health → red, decision branches on severity → critical path runs a parallel alert block then a try/catch incident push (catch logs the failure); normal path sends one notification; both converge. Combines decision + parallel + try_catch with converging edges in one realistic flow. Full automation suite 180 green. Browser-verified: critical path ran start→triage→alert(parallel ×2)→push_incident(catch on http failure)→converge; normal path took the single-notify branch; the designer renders the nested structure with correct construct icons + conditional edges. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single-construct tests cover
loop/parallel/try_catchin isolation; nothing exercised their interactions when nested. This adds both the deterministic proof and a worked composite showcase example (the recommendation from the "should we add more complex flows?" discussion — value is in composition, not more single-concept coverage).Engine tests —
nested-composition.test.ts(+3)parallel-branch/inner_par; the parallel node →loop-body/outer_loop); the after-block continuation runs once.Showcase —
showcase_project_escalationOn health → red: a
decisionbranches on severity → the critical path runs aparallelalert block then atry/catchincident push (catch logs the failure); the normal path sends one notification; both converge. Combines decision + parallel + try_catch with converging edges in one realistic flow.Test plan
start → triage → alert(parallel ×2, tagged parallel-branch) → push_incident(http failed → catch tagged catch) → converge, completed; normal path (budget ≤ 200k) took the single-notify branch and skipped parallel/try_catch; the designer renders the nested structure with correct construct icons (diamond/fork/shield) + conditional edges; the Runs panel shows the folded nesting.🤖 Generated with Claude Code