tools: remove envinfo from our workflows#64259
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Review requested:
|
There was a problem hiding this comment.
LGTM. FWIW this is currently what we are getting from the output, it seems most of them can be obtained elsewhere, or we can echo specific ones out if we find them useful (I think GCC version is useful at least)
System:
OS: Linux 6.1 Ubuntu 24.04.4 LTS 24.04.4 LTS (Noble Numbat)
CPU: (1) x64 AMD EPYC 9V74 80-Core Processor
Memory: 4.24 GB / 4.83 GB
Container: Yes
Shell: 5.2.21 - /bin/bash
Binaries:
Node: 24.18.0 - /opt/hostedtoolcache/node/24.18.0/x64/bin/node
npm: 11.16.0 - /opt/hostedtoolcache/node/24.18.0/x64/bin/npm
Managers:
Apt: 2.8.3 - /usr/bin/apt
pip3: 24.0 - /usr/bin/pip3
Utilities:
7z: 23.01 - /usr/bin/7z
Make: 4.3 - /usr/bin/make
GCC: 13.3.0 - /usr/bin/gcc
Git: 2.54.0 - /usr/bin/git
Git LFS: 3.7.1 - /usr/bin/git-lfs
Mercurial: 6.7.2 - /usr/bin/hg
Curl: 8.5.0 - /usr/bin/curl
OpenSSL: 3.0.13 - /usr/bin/openssl
Virtualization:
Docker: 29.5.2 - /usr/bin/docker
Languages:
Bash: 5.2.21 - /usr/bin/bash
Perl: 5.38.2 - /usr/bin/perl
Python: 3.12.3 - /usr/bin/python
Python3: 3.12.3 - /usr/bin/python3
Databases:
SQLite: 3.45.1 - /usr/bin/sqlite3
The dependency was added in #32450 I guess back then folks didn't really think as much about the implications of adding an npm package...
For Node.js builds if we're not already running running |
Probably not given that we're not using GCC on any GHA ;) (actually, we do use it on test-shared's Linux runners) Anyway, we do have Lines 658 to 659 in 5922197 |
#64117 took the approach of pinning to a specific version, which, given that it's an npm package with 0 deps, is an effective strategy. However, it adds maintenance burden (e.g. if envinfo makes a security release, somebody needs to remember to update the workflow), so here I am with a different approach: let's get rid of it. It can provide useful info if something breaks, but for most cases, it's just 5s/runner of wasted download and compute time.