diagnostics_channel: replace using with try-finally

[ayush23chaudhary]

Fixes: #64230

Description

This PR replaces instances of the experimental using syntax with try...finally blocks inside lib/diagnostics_channel.js.

Since Explicit Resource Management is still a flagged feature in V8, encountering using in core causes a segfault when running Node with the --no-js-explicit-resource-management flag. This refactor maintains the exact same resource cleanup semantics by manually calling [SymbolDispose]() in a finally block, avoiding the flagged syntax entirely.

Example of Refactor

Before:

using scope = this.withStoreScope(data);
return ReflectApply(fn, thisArg, args);

After

const scope = this.withStoreScope(data);
try {
  return ReflectApply(fn, thisArg, args);
} finally {
  scope[SymbolDispose]();
}

[Copilot]

Pull request overview

This PR removes the experimental using syntax from lib/diagnostics_channel.js, replacing it with equivalent try...finally disposal to avoid crashes when Node is run with --no-js-explicit-resource-management.

Changes:

• Replaced using statements with explicit try...finally blocks that invoke [SymbolDispose]().
• Updated scope handling in ActiveChannel, BoundedChannel, and TracingChannel paths to ensure disposal occurs reliably without relying on flagged syntax.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Renegade334]

DisposableStack is also a flagged global.

[ayush23chaudhary]

@Renegade334, I did not realize DisposableStack was part of the same flagged feature. I've replaced it with a standard array that manually iterates in reverse during disposal. Just pushed the update.

[anonrig]

Please add at least a test

[Renegade334]

#stack is not disposed by the constructor. This code should be removed, and the try ... finally block in the constructor is not needed.

[Renegade334]

Suggested change

	const stack = [];
	// TODO: use native DisposableStack once supported in core
	const stack = [];

[Renegade334]

Suggested change

	for (let i = this.#stack.length - 1; i >= 0; i--) {
	this.#stack[i][SymbolDispose]();
	}
	this.#stack = undefined;
	const stack = this.#stack;
	this.#stack = undefined;
	for (let i = stack.length - 1; i >= 0; i--) {
	stack[i][SymbolDispose]();
	}

Matches the order of operations of DisposableStack.prototype.dispose(), in case anything touches the stack during disposal.

[Renegade334]

Can any of the store disposers ever throw? If so, we need error handling here as well.