ci: adopt centralized reusable workflows#3
Merged
Conversation
Replace the inline QA jobs with a call to the nlemoine/.github php-qa.yml reusable workflow (cs-tool: ecs), and switch the release workflow to the shared release-please.yml. Both pinned to the same SHAs used across the other repos.
rmccue/requests 2.0.1 is the first release where Hooks::dispatch() sorts callbacks by priority (ksort), which the WordPress adapter relies on. The symfony floor moves to 7.4.
Symfony HTTP Client 8.1 adds a max_connect_duration default option. The adapter did not recognize it and threw UnsupportedFeatureException on every request. Mark it ignored, the same way max_duration is.
When the client is constructed with a null file and the URL does not point to a .php file, the command array passed to Process contained a null element. Throw a RuntimeException with an explicit message.
Drop the deprecated strict prepared set (ECS 13 rejects it) and point the skip path at src/Runtime/functions.php instead of the old, removed src/headers.php. Apply the resulting fixer changes.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the inline QA jobs with a call to the nlemoine/.github php-qa.yml reusable workflow (cs-tool: ecs), and switch the release workflow to the shared release-please.yml. Both pinned to the same SHAs used across the other repos.