Remove timestamp fallbacks for non-batched publishing#141
Draft
mjohanse-emr wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR removes the timestamp fallbacks from non-batched publish measurement.
Before this change, if
timestampwas not provided, we would fall back to one of these two values:The desire is to conceptually move this logic into the Datastore Server. The implementation may not look exactly the same, but the goal on the client side is just to pass through the provided timestamp without altering it.
Why should this Pull Request be merged?
AB#3926275
We want to remove the timestamp fallbacks until we decide how to handle it on the server side.
What testing has been done?
I updated two unit tests to check for a default
PrecisionTimestampif notimestampis provided.All unit tests and acceptance tests pass.