Update batch publishing to fallback to t0/now if timestamp is unset#140
Draft
mjohanse-emr wants to merge 1 commit into
Draft
Update batch publishing to fallback to t0/now if timestamp is unset#140mjohanse-emr wants to merge 1 commit into
mjohanse-emr wants to merge 1 commit into
Conversation
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
mjohanse-emr
commented
Jun 17, 2026
| ) -> None: | ||
| timestamp = datetime.now(tz=std_datetime.timezone.utc) | ||
| waveform_values = [1.0, 2.0, 3.0] | ||
| analog_waveforms = [ |
Contributor
Author
There was a problem hiding this comment.
Should these tests use more than one waveform for completeness?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
AB#3926275
Updates the Publish Measurement Batch process to perform the following fall-backs if the
timestampparameter is left unset.t0, assignt0for the timestamp.t0or publishing any other type, assign the current time for the timestamp.Why should this Pull Request be merged?
The non-batch case already performs these fall-backs, so this PR is bringing the batched publishing case up to speed. We would like the behavior to be as consistent as possible when
timestampis not specified.What testing has been done?
I created batched versions of the unit tests that cover this timestamp fall-back behavior. All acceptance and unit tests pass.