Skip to content

🕵️ Add sharereview support#8052

Draft
AndyScherzinger wants to merge 8 commits into
mainfrom
feat/noid/sharereview
Draft

🕵️ Add sharereview support#8052
AndyScherzinger wants to merge 8 commits into
mainfrom
feat/noid/sharereview

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Target version: main

Summary

Enabled the share review app to retrieve general share information and enabled the app to delete shares.

TODO

  • run CI
  • clarify share meta data

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@AndyScherzinger AndyScherzinger force-pushed the feat/noid/sharereview branch from c36332f to a421be9 Compare June 11, 2026 14:37
@AndyScherzinger
feat(sharereview): add listener registering Deck as a share source
237d72b 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(sharereview): add ShareReviewSource with constructor and getName()
19dba8b 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(sharereview): implement getShares() with board name lookup via JOIN
58f8796 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
feat(sharereview): implement deleteShare() via direct SQL with logging
828564d 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/sharereview branch from a421be9 to 935be19 Compare June 11, 2026 16:17
@AndyScherzinger
feat(sharereview): register ShareReview listener on SourceEvent
33cc523 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(sharereview): apply coding standards and Psalm fixes
d611178 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
test(sharereview): add unit tests for ShareReviewSource
21a7e20 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix(sharereview): harden and optimize implementation and testing
6f0363f 
Assisted-by: Claude Code:claude-sonnet-4-6
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/noid/sharereview branch from 935be19 to 6f0363f Compare June 11, 2026 16:18
AndyScherzinger
AndyScherzinger commented Jun 11, 2026
View reviewed changes
Comment thread lib/ShareReview/ShareReviewSource.php
'recipient' => (string)$share['participant'],
'permissions' => $this->computePermissions($share),
'password' => false,
'time' => '1970-01-01 01:00:00',

@AndyScherzinger AndyScherzinger Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we do not have a creation/modification date of share records

@AndyScherzinger AndyScherzinger Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified, no creation/modification metadata present

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96709 was 93102 (+3.87%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96680 was 93102 (+3.84%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@nextcloud nextcloud deleted a comment from github-actions Bot Jun 11, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud will be requested when the pull request is marked ready for review luka-nextcloud is a code owner

@grnd-alt grnd-alt Awaiting requested review from grnd-alt grnd-alt will be requested when the pull request is marked ready for review grnd-alt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

2. developing AI assisted enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndyScherzinger