Skip to content

ci: use INFO loglevel in the Redis deploy jobs#893

Merged
oleksandr-nc merged 1 commit into
mainfrom
fix/ci-php-stack-size-check
Jun 12, 2026
Merged

ci: use INFO loglevel in the Redis deploy jobs#893
oleksandr-nc merged 1 commit into
mainfrom
fix/ci-php-stack-size-check

Conversation

@oleksandr-nc

@oleksandr-nc oleksandr-nc commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Since June 5 the two Redis jobs failed every run: occ crashes during setup with "Maximum call stack size reached during compilation" (or a segfault if the PHP 8.3 stack check is disabled). The root cause is on current server master since nextcloud/server#59002: the deprecated RedisFactory alias logs a deprecation at debug level, writing that entry resolves IRequest in the middle of DI construction, and the container recurses until the stack overflows. The crash needs a Redis memcache plus loglevel 0, and INFO level is fine for the CI anyway, so use that in the Redis jobs.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 91899d1c-45e7-428d-afae-40864b42ef7d

📥 Commits

Reviewing files that changed from the base of the PR and between 873f58e and dbb95ca.

📒 Files selected for processing (1)
  • .github/workflows/tests-deploy.yml

📝 Walkthrough

Walkthrough

This PR updates two Redis-hosted Nextcloud CI jobs in .github/workflows/tests-deploy.yml to set Nextcloud's system loglevel to 1 instead of 0 by running ./occ config:system:set loglevel --value=1 --type=integer in both nc-host-app-docker-redis and nc-host-app-docker-redis-deploy-options. The previous --value=0 commands were removed; no other workflow steps shown were modified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: adjusting loglevel to INFO in Redis deploy jobs to resolve the June 5 crash issue.
Description check ✅ Passed The description is directly related to the changeset, explaining the root cause of the Redis job failures and why loglevel is being changed to 1 (INFO level).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oleksandr-nc oleksandr-nc force-pushed the fix/ci-php-stack-size-check branch from c48fefe to 873f58e Compare June 12, 2026 07:52

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 73476df4-5141-4481-91db-514973955356

📥 Commits

Reviewing files that changed from the base of the PR and between c48fefe and 873f58e.

📒 Files selected for processing (1)
  • .github/workflows/tests-deploy.yml

Comment thread .github/workflows/tests-deploy.yml Outdated
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
@oleksandr-nc oleksandr-nc force-pushed the fix/ci-php-stack-size-check branch from 873f58e to dbb95ca Compare June 12, 2026 08:10
@oleksandr-nc oleksandr-nc changed the title fix-ci: set zend.max_allowed_stack_size=-1 to avoid false-positive stack overflow fatals ci: use INFO loglevel in the Redis deploy jobs Jun 12, 2026
@oleksandr-nc oleksandr-nc merged commit f1ab624 into main Jun 12, 2026
49 of 50 checks passed
@oleksandr-nc oleksandr-nc deleted the fix/ci-php-stack-size-check branch June 12, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant