Skip to content

Default first_name/last_name to empty string in profile import#11759

Merged
nbudin merged 2 commits into
mainfrom
fix-null-first-last-name
Jun 23, 2026
Merged

Default first_name/last_name to empty string in profile import#11759
nbudin merged 2 commits into
mainfrom
fix-null-first-last-name

Conversation

@nbudin

@nbudin nbudin commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Exporters omit name fields from profiles when they are blank, so prof[:first_name] and prof[:last_name] can be nil. Passing nil directly to assign_form_response_attributes triggers a NOT NULL violation on the user_con_profiles table. .to_s converts nil to "" safely.

Exporters omit name fields from profiles when they are blank, so
prof[:first_name] and prof[:last_name] can be nil. Passing nil directly
to assign_form_response_attributes triggers a NOT NULL violation on the
user_con_profiles table. .to_s converts nil to "" safely.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nbudin nbudin added bug patch Bumps the patch version number on release labels Jun 23, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
app/javascript/BuiltInFormControls/AddFileModal.tsx 🔴 33.33% 🔴 0% 🔴 -33.33%
app/javascript/BuiltInFormControls/LiquidInput.tsx 🟠 60% 🟠 57.5% 🔴 -2.5%
app/services/import_convention_data_service.rb 🟢 94.07% 🟢 94.09% 🟢 0.02%
Overall Coverage 🟢 54.32% 🟢 54.29% 🔴 -0.03%

Minimum allowed coverage is 0%, this run produced 54.29%

@nbudin nbudin merged commit b2eb8f5 into main Jun 23, 2026
25 checks passed
@nbudin nbudin deleted the fix-null-first-last-name branch June 23, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug patch Bumps the patch version number on release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant