[codex] fix Linux OS release parsing#24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
VERSION_IDvalues for NixOS, Rocky Linux, and AlmaLinuxos.releaseintomajorandminor, matchingos.distro.release.BUILD_ID=rollingfrom being treated as an operating system release.Why
The NixOS lab VM showed
os.distro.release.major = "26"whileos.release.major = "26.05". A sweep of the existing lab binaries found the same class of mismatch on Rocky 9 and AlmaLinux 9.Validation
go test ./internal/engine -run 'TestParseLinuxOSRelease|TestCurrentOSRelease'go test ./...go vet ./...make buildgit diff --checkNote: existing lab binaries were checked across the running VM fleet. Uploading the newly built candidate binaries for full remote validation was blocked by sandbox policy pending explicit approval.