Skip to content

Deepen discovery input surface#22

Merged
ncode merged 1 commit into
mainfrom
juliano/deepen-discovery-input-surface
Jun 23, 2026
Merged

Deepen discovery input surface#22
ncode merged 1 commit into
mainfrom
juliano/deepen-discovery-input-surface

Conversation

@ncode

@ncode ncode commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add an OpenSpec change for deepening the discovery input surface.
  • Move config, external fact, cache, and query planning into an internal engine discovery planner.
  • Keep CLI-owned behavior in internal/app while routing discovery inputs through engine.EngineConfig.

Validation

  • gofmt -w cache_test.go engine_contract_test.go engine_test.go internal/app/app.go internal/app/app_test.go internal/engine/engine.go internal/engine/discovery_plan.go
  • go test . ./internal/engine ./internal/app
  • go test ./...
  • go vet ./...
  • go test -race . ./internal/engine ./internal/app
  • make build
  • make test outside the sandbox
  • openspec validate deepen-discovery-input-surface --strict
  • git diff --check
  • ocr review returned 0 comments on the rerun

GitHub Actions are configured for pull requests to main, so CI should start from this PR rather than the feature-branch push.

@ncode ncode marked this pull request as ready for review June 23, 2026 19:59
@ncode ncode merged commit 8b7e7f7 into main Jun 23, 2026
37 checks passed
@ncode ncode deleted the juliano/deepen-discovery-input-surface branch June 24, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant