chore: ⬆️ Update CrispStrobe/CrispASR to f0491231f604f0f1ef9bfbf6ffa80d308a4da169#10177
Open
localai-bot wants to merge 2 commits into
Open
chore: ⬆️ Update CrispStrobe/CrispASR to f0491231f604f0f1ef9bfbf6ffa80d308a4da169#10177localai-bot wants to merge 2 commits into
f0491231f604f0f1ef9bfbf6ffa80d308a4da169#10177localai-bot wants to merge 2 commits into
Conversation
7536945 to
935f577
Compare
3831a05a95689648444bc38b8cca3ad192e76cc47f090946e0efa6184203a1d0f35e1051502a08dc
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
935f577 to
5a73a18
Compare
7f090946e0efa6184203a1d0f35e1051502a08dcf0491231f604f0f1ef9bfbf6ffa80d308a4da169
Upstream CrispASR f0491231 renamed the main library CMake target from `crispasr` to `crispasr-lib` (keeping OUTPUT_NAME crispasr, adding only `add_library(whisper ALIAS crispasr-lib)`). The wrapper still referenced the old target name, so CMake degraded `crispasr` to a plain `-lcrispasr` link flag and ld failed with `cannot find -lcrispasr` across the whole backend-build matrix. Point target_link_libraries at the new `crispasr-lib` target. Verified locally: CMake configure now resolves the gocrispasr link line to the real sources/CrispASR/src/libcrispasr.a archive instead of -lcrispasr. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude:opus-4.8 [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: https://github.com/CrispStrobe/CrispASR/compare/13d54e110e1538e0f0bc3af0680b9ab246cfb48d..f0491231f604f0f1ef9bfbf6ffa80d308a4da169