chore: drop stale zkTrie comment + flip sample genesis useZktrie=false#1000
Draft
curryxbo wants to merge 1 commit into
Draft
chore: drop stale zkTrie comment + flip sample genesis useZktrie=false#1000curryxbo wants to merge 1 commit into
curryxbo wants to merge 1 commit into
Conversation
Part of PR-A (zkTrie state cleanup + post-Jade trusted-prefix). MPT is the confirmed terminal state; pre-Jade history is a trusted prefix. Changes: - node/core/executor.go: drop stale "until Geth enables snapshot with zkTrie" reference in the full-sync comment. - node/ops-morph/genesis-l2.json, genesis_geth.json: set scroll.useZktrie false (MPT terminal state). NOT touched (deliberate): go.mod indirect go-ethereum dependency — must wait for the go-ethereum PR-A to merge before bumping; running `go mod tidy` now would pull it back. Submodule pointer left as-is. go build ./... passes in node/. Draft PR-A. Do not push. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy zkTrie cleanup (monorepo side), companion to the go-ethereum zkTrie cleanup.
Scope
node/core/executor.go: drop a stale snap-sync zkTrie comment.node/ops-morph/genesis-l2.json,genesis_geth.json: flip stale sampleuseZktrie:truetofalse(production genesis is already false).Build
go build ./...innode/passes.Context
The indirect dependency
scroll-tech/zktriewill drop out viago mod tidyonce the upstream go-ethereum cleanup lands.Design doc: https://larkfive.sg.larksuite.com/wiki/Qan7w367ji6qn1kU2XTlPzOagte
🤖 Generated with Claude Code